[css-multicol] Pass at incorporating the new model plus clarification in the issue re naming #3999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The gap is the same size in all rows and lines in the container.
Contributor
Author
|
@frivoal updated based on our discussion today. |
fantasai
requested changes
Jun 6, 2019
Collaborator
fantasai
left a comment
There was a problem hiding this comment.
First set of review comments...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1072
Given the fiddliness of this I have opened a PR. I'm just looking at this first part now, with regard to the inclusion of the new model plus the naming we discussed. If we can get this right I'll go through the spec looking for any naming problems that fall out of it. I'll address the parts that deal with spanners specifically separately. I wanted to sort all these anonymous boxes first.
I think we essentially add an extra container (2 in @frivoal's writeup in the issue) when we do this, I've attempted to write that in. We end up with multiple multicol rows in the case of pagination (these contain the box 1 in @frivoal's writeup) and spanners. In future we might then add the concept or rows being created in the block dimension by height restricting the row.
This means a bit of a change to the text below that about gaps, and clarification that gaps are the same across all rows and lines in the container, even if we have multiple rows, or a spanner creates multiple lines.
Please let me know any thoughts.